[Intel-gfx] [PATCH 1/2] drm/i915: mask RPS IRQs properly when disabling RPS

[Chris Wilson]

On Mon, Dec 01, 2014 at 02:29:11PM -0200, Paulo Zanoni wrote:
> 2014-11-20 19:01 GMT-02:00 Imre Deak <imre.deak at intel.com>:
> > Atm, igt/gem_reset_stats can trigger the recently added WARN on
> > left-over PM_IIR bits in gen6_enable_rps_interrupts(). There are two
> > reasons for this:
> > 1. we call intel_enable_gt_powersave() without a preceeding
> >    intel_disable_gt_powersave()
> > 2. gen6_disable_rps_interrupts() doesn't mask interrupts in PM_IMR
> 
> We don't do this, but we mask stuff through GEN6_PMINTRMSK. Shouldn't
> this be enough to prevent IIR from changing?
> 
> Chris?

It should. We should be doing both really, use PM_IMR to treat
IMR/IIR/IER consistently with other interrupts, and use the special
PMINTRMASK as part of rps power tuning.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre