[Intel-gfx] [PATCH v2] drm/i915: Reject modeset when the same digital port is used more than once

[Chris Wilson]

On Tue, Dec 02, 2014 at 02:10:46PM +0200, ville.syrjala at linux.intel.com wrote:
> +	if (!check_digital_port_conflicts(dev)) {

Being picky:

if not check digital port for conflicts, report error.

It reads backwards. Perhaps 

if (conflicting_digital_port_config(dev)) return -EINVAL;

> +		DRM_DEBUG_KMS("rejecting conflicting digital port configuration\n");
> +		return ERR_PTR(-EINVAL);
> +	}

Regarding getting more information back to the user about the error
message, we could with have a connector/crtc property, a procfs file or
an ioctl to grab a string describing the last error. A LastError
property blob might be the most convenient. Though I am not sure how
outlandish this idea is.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre