[Intel-gfx] [PATCH] drm/i915: Don't display nonsensical values in i915_ddb_info on gen < 9

Daniel Vetter daniel at ffwll.ch
Thu Dec 4 03:01:39 PST 2014


On Wed, Dec 03, 2014 at 10:19:24PM +0200, Ville Syrjälä wrote:
> On Wed, Dec 03, 2014 at 05:33:24PM +0000, Damien Lespiau wrote:
> > When playing around with debugfs and a HSW machine I noticed that we
> > were displaying some garbled value in i915_ddb_info. This debugfs file
> > is only meaningful for gen9+, so don't display anything on earlier
> > platforms.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 6c16939..d0e445e 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2743,6 +2743,9 @@ static int i915_ddb_info(struct seq_file *m, void *unused)
> >  	enum pipe pipe;
> >  	int plane;
> >  
> > +	if (INTEL_INFO(dev)->gen < 9)
> > +		return 0;
> 
> -ENODEV or somesuch? But I guess we're not too consistent how we deal
> with such things, so seems OK as is too:
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list