[Intel-gfx] [PATCH i-g-t 4/4] tests/kms_flip: Target the back buffer with the dummy load

Daniel Vetter daniel at ffwll.ch
Fri Dec 5 13:09:01 PST 2014


On Fri, Dec 05, 2014 at 05:13:17PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Aim the dummy load to the current back buffer instead if the front
> buffer. Assuming the idea is to get the next flip to be stuck behind
> the dummy load?

Yeah that makes more sense. Ack on the entire series. I still think it'd
be useful to extract a solid dummy load tuner into lib, but that's a bit
more work really. I'll do an igt jira for it so we don't forget.
-Daniel

> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  tests/kms_flip.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 5d5302d..f847a86 100644
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -878,15 +878,15 @@ static unsigned int run_test_step(struct test_output *o)
>  	if (o->flags & TEST_DPMS_OFF_OTHERS)
>  		dpms_off_other_outputs(o);
>  
> +	if (!(o->flags & TEST_SINGLE_BUFFER))
> +		o->current_fb_id = !o->current_fb_id;
> +
>  	if (o->flags & TEST_WITH_DUMMY_BCS)
>  		emit_dummy_load__bcs(o, 1);
>  
>  	if (o->flags & TEST_WITH_DUMMY_RCS)
>  		emit_dummy_load__rcs(o, 1);
>  
> -	if (!(o->flags & TEST_SINGLE_BUFFER))
> -		o->current_fb_id = !o->current_fb_id;
> -
>  	if (o->flags & TEST_FB_RECREATE)
>  		recreate_fb(o);
>  	new_fb_id = o->fb_ids[o->current_fb_id];
> -- 
> 2.0.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list