[Intel-gfx] [PATCH 00/11] FBC improvements + frontbuffer tracking conversion

Paulo Zanoni przanoni at gmail.com
Mon Dec 8 08:09:09 PST 2014


From: Paulo Zanoni <paulo.r.zanoni at intel.com>

Hi

This series does some minor fixes to the FBC code and also ports it to use the
new front buffer tracking infrastructure.

Patches 1-2 are the transition from intel_pm.c to intel_fbc.c. Rodrigo's point
is that it's better to move to intel_fbc.c first because then it's going to be
easier to bisect any changes introduced by the series, and I agree with him.
Also, I don't think we're going to bisect any FBC changes that happened before
this series anyway.

I tested this series both on IGT's kms_fbc_crc.c and on another set of tests
that I wrote on my own (yes, NIH syndrome). I plan to move all the new tests
that I wrote to kms_fbc_crc, but I still didn't do this and it will take some
time.

With the series applied, HSW passes all the tests. I still see some FIFO
underruns on my BDW machine - not introduced by the series - so I don't think we
should enable FBC by default yet.

Thanks,
Paulo

Paulo Zanoni (9):
  drm/i915: don't try to find crtcs for FBC if it's disabled
  drm/i915: don't keep reassigning FBC_UNSUPPORTED
  drm/i915: change dev_priv->fbc.plane to dev_priv->fbc.crtc
  drm/i915: pass which operation triggered the frontbuffer tracking
  drm/i915: also do frontbuffer tracking on pwrites
  drm/i915: add fronbuffer tracking to FBC
  drm/i915: extract intel_fbc_find_crtc()
  drm/i915: HSW+ FBC is tied to pipe A
  drm/i915: gen5+ can have FBC with multiple pipes

Rodrigo Vivi (2):
  drm/i915: Move FBC stuff to intel_fbc.c
  drm/i915: Introduce FBC DocBook.

 Documentation/DocBook/drm.tmpl             |   5 +
 drivers/gpu/drm/i915/Makefile              |   1 +
 drivers/gpu/drm/i915/i915_drv.h            |  21 +-
 drivers/gpu/drm/i915/i915_gem.c            |  14 +-
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |   2 +-
 drivers/gpu/drm/i915/i915_suspend.c        |   2 +-
 drivers/gpu/drm/i915/intel_display.c       |  27 +-
 drivers/gpu/drm/i915/intel_drv.h           |  24 +-
 drivers/gpu/drm/i915/intel_fbc.c           | 758 +++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_frontbuffer.c   |  29 +-
 drivers/gpu/drm/i915/intel_pm.c            | 651 +------------------------
 drivers/gpu/drm/i915/intel_ringbuffer.c    |  41 +-
 drivers/gpu/drm/i915/intel_ringbuffer.h    |   1 -
 drivers/gpu/drm/i915/intel_sprite.c        |   6 +-
 14 files changed, 833 insertions(+), 749 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/intel_fbc.c

-- 
2.1.3



More information about the Intel-gfx mailing list