[Intel-gfx] [PATCH 07/11] drm/i915: also do frontbuffer tracking on pwrites

[Rodrigo Vivi]

wondering if this fixes: https://bugs.freedesktop.org/show_bug.cgi?id=87143

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

On Mon, Dec 8, 2014 at 8:55 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Mon, Dec 08, 2014 at 02:09:16PM -0200, Paulo Zanoni wrote:
>> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>>
>> We need this for FBC, and possibly for PSR too.
>>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> Hm, this might fix some cursor update failures if userspace only pwrites
> and doesn't follow suite with a cursor ioctl update call. Not sure this
> ever happens, but definitely makes sense.
> -Daniel
>
>> ---
>>  drivers/gpu/drm/i915/i915_gem.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>> index 7ef12e8..b8c906e 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -1117,6 +1117,10 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
>>                       ret = i915_gem_phys_pwrite(obj, args, file);
>>               else
>>                       ret = i915_gem_shmem_pwrite(dev, obj, args, file);
>> +
>> +             intel_fb_obj_flush(obj, false, ORIGIN_CPU);
>> +     } else {
>> +             intel_fb_obj_flush(obj, false, ORIGIN_GTT);
>>       }
>>
>>  out:
>> --
>> 2.1.3
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br