[Intel-gfx] [PATCH 03/11] drm/i915: don't try to find crtcs for FBC if it's disabled

[Daniel Vetter]

On Fri, Dec 12, 2014 at 04:53:45PM -0800, Rodrigo Vivi wrote:
> On Mon, Dec 8, 2014 at 8:09 AM, Paulo Zanoni <przanoni at gmail.com> wrote:
> > From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >
> > .. because it would be a waste of time, so move the place where the
> > check is done. Also, with this we won't risk printing "more than one
> > pipe active, disabling compression" or "no output, disabling" when FBC
> > is actually disabled.
> >
> > This patch also represents a small behavior difference when using
> > i915.powersave=0: it is now exactly the same as i915.enable_fbc=0 on
> > this part of the code.
> 
> I always ask myself if we should continue using this i915.powersave here.
> I vaguely remember someone complaining when I tried to re-org this
> i915.powersave making it a umbrealla for all powersaving features and
> the complain was to avoid more than one variable for feature... to
> avoid superset of parameters, or something like that.
> 
> Or if we keep this here shouldn't we also put this to disable psr?
> 
> Anyway this can be another patch. Daniel, please let me know what you
> want with this parameters that I can change that later.

Imo powersave has outlived its usefulness and it can die. We've long ago
started having specific options for this. So maybe create a patch to mark
it as a debug option and then 1 kernel later kill it?
-Daneil
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch