[Intel-gfx] [PATCH] drm/i915: Call the lrc irq handler correctly

Daniel Vetter daniel at ffwll.ch
Mon Dec 15 00:54:27 PST 2014


On Wed, Dec 10, 2014 at 04:56:39PM +0000, Daniel, Thomas wrote:
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch]
> > Sent: Wednesday, December 10, 2014 4:44 PM
> > To: Intel Graphics Development
> > Cc: Daniel Vetter; Daniel, Thomas; Vetter, Daniel
> > Subject: [PATCH] drm/i915: Call the lrc irq handler correctly
> > 
> > We consistently use the _irq_handler postfix for functions called in hardirq
> > context. Especially when it's a non-static function hardirq is a crazy enough
> > calling context to warrant this level of ocd. So rename it.
> > 
> > Cc: Thomas Daniel <thomas.daniel at intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > ---
> Possible to rename the patch "Name the lrc irq handler correctly" before
> merging?  Sounds like it was being called from the wrong place.

Definitely agreed since I've changed the subject locally 1 second after
hitting send ;-)
> 
> No problem with this renaming though so:
> Reviewed-by: Thomas Daniel <thomas.daniel at intel.com>

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list