[Intel-gfx] [PATCH v2 3/3] drm/i915: Disable PSMI sleep messages on all rings around context switches

[Chris Wilson]

On Tue, Dec 16, 2014 at 08:44:33AM +0000, Chris Wilson wrote:
>  	/* WaProgramMiArbOnOffAroundMiSetContext:ivb,vlv,hsw,bdw,chv */
> -	if (INTEL_INFO(ring->dev)->gen >= 7)
> +	if (INTEL_INFO(ring->dev)->gen >= 7) {
>  		intel_ring_emit(ring, MI_ARB_ON_OFF | MI_ARB_DISABLE);
> -	else
> -		intel_ring_emit(ring, MI_NOOP);
> +		if (num_rings) {
> +			intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(num_rings));
> +			for_each_ring(engine, to_i915(ring->dev), i) {
> +				if (i == RCS)
> +					continue;

I would have preferred to have written

	if (engine == ring)
		continue;

here instead. And s/engine/signaller/
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre