[Intel-gfx] [RFC 00/22] Gen7 batch buffer command parser

[Volkin, Bradley D]

On Wed, Feb 05, 2014 at 11:17:25AM -0800, Daniel Vetter wrote:
> On Wed, Feb 5, 2014 at 8:00 PM, Volkin, Bradley D
> <bradley.d.volkin at intel.com> wrote:
> > To test/merge, we'd have to change the series to take out the part where
> > patch 02/13 sets I915_DISPATCH_SECURE to avoid a BUG_ON() when i915.enable_cmd_parser=1.
> > But yes, otherwise the parsing works and I think should be sufficient for
> > what Chris indicated he wants to test.
> 
> Oh, I didn't spot this but this needs to be moved way back in the
> series - we can only set the bit once we have the batchbuffer copy
> logic in place. Otherwise there's a security hole open since userspace
> is free to frob the batch residing in the ppgtt, which we just can't
> prevent.

Good point. I'll take it out and we can add it as part of the batch copy work.

> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch