[Intel-gfx] [PATCH] drm/i915: don't call swsci_setup on resume

[Daniel Vetter]

On Thu, Feb 6, 2014 at 4:19 PM, Paulo Zanoni <przanoni at gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> This function is used to discover which swsci callbacks the machine
> supports. It calls swsci() 3 times, and usually takes a considerable
> number of milliseconds to finish.
>
> I don't see a reason for a change on the supported callbacks between
> boot and resume, so use the values retrieved at boot time forever,
> making resume a little bit faster.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

I think we could simply not call opregion_setup in our thaw function.
The actual runtime setup is already split out into _init/fini
functions, so if anything in opregion_setup needs to be done at resume
we could simply move that. But afaict the split looks sane already.

That way the init sequence is much less tricky than the conditional
swsci_setup in your patch. The only write we have in _setup is
ASLE_ARDY_NOT_READY, but that's the default state - the driver only
needs to signal readiness once everything is up (in _init) and tell
the bios again that it's gone in _fini.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch