[Intel-gfx] [PATCH v3 01/12] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h

[Daniel Vetter]

On Thu, Feb 06, 2014 at 08:34:42PM +0530, sagar.a.kamble at intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The rotation property stuff should be standardized among all drivers.
> Move the bits to drm_crtc.h from omap_drv.h.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Tested-by: Sagar Kamble <sagar.a.kamble at intel.com>

Patches which touch code outside of i915 must be submitted to the
dri-devel mailing list. Also, since you're touching a driver please also
cc the driver maintainers/authors (Tomi/Rob in this case) so that they'll
notice the patch.

scripts/get_maintainers.pl can help you with adding a reasonable Cc: list
to the sob section of your patches.
-Daniel

> ---
>  drivers/gpu/drm/omapdrm/omap_drv.h | 7 -------
>  include/drm/drm_crtc.h             | 8 ++++++++
>  2 files changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h
> index 428b2981..aac8e10 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.h
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.h
> @@ -119,13 +119,6 @@ struct omap_drm_private {
>  	struct omap_drm_irq error_handler;
>  };
>  
> -/* this should probably be in drm-core to standardize amongst drivers */
> -#define DRM_ROTATE_0	0
> -#define DRM_ROTATE_90	1
> -#define DRM_ROTATE_180	2
> -#define DRM_ROTATE_270	3
> -#define DRM_REFLECT_X	4
> -#define DRM_REFLECT_Y	5
>  
>  #ifdef CONFIG_DEBUG_FS
>  int omap_debugfs_init(struct drm_minor *minor);
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 71727b6..d5c46c1 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -65,6 +65,14 @@ struct drm_object_properties {
>  	uint64_t values[DRM_OBJECT_MAX_PROPERTY];
>  };
>  
> +/* rotation property bits */
> +#define DRM_ROTATE_0	0
> +#define DRM_ROTATE_90	1
> +#define DRM_ROTATE_180	2
> +#define DRM_ROTATE_270	3
> +#define DRM_REFLECT_X	4
> +#define DRM_REFLECT_Y	5
> +
>  /*
>   * Note on terminology:  here, for brevity and convenience, we refer to connector
>   * control chips as 'CRTCs'.  They can control any type of connector, VGA, LVDS,
> -- 
> 1.8.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch