[Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

[Goel, Akash]

> 1. GFX_MODE_GEN7 (Enabling TLB invalidate)
>> The changelog needs to explain why. According to the spec this is a pessimisation.
Ok, Will look into this. 

> 2. MI_MODE (Enabling MI Flush)
>> And this is out-of-date. Doesn't describe the actual change nor why.
Sorry I did not update the commit message properly.
Actually I have reverted the change, enabling of MI_FLUSH, in this new version of the patch, as you also said this is obsolete. 

Best Regards
Akash

-----Original Message-----
From: Chris Wilson [mailto:chris at chris-wilson.co.uk] 
Sent: Friday, February 07, 2014 6:01 PM
To: Goel, Akash
Cc: intel-gfx at lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

On Fri, Feb 07, 2014 at 05:52:12PM +0530, akash.goel at intel.com wrote:
> From: Akash Goel <akash.goel at intel.com>
> 
> Modified programming of following 2 regs in Render ring initialisation fn.
> 1. GFX_MODE_GEN7 (Enabling TLB invalidate)

The changelog needs to explain why. According to the spec this is a pessimisation.

-Chris

--
Chris Wilson, Intel Open Source Technology Centre