[Intel-gfx] [PATCH 1/2] drm: expose subpixel order name routine v2

[Daniel Vetter]

On Fri, Feb 07, 2014 at 12:48:14PM -0800, Jesse Barnes wrote:
> Just like we have for connector type etc.
> 
> v2: drop static array (Chris)
> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Cc: dri-devel is missing. Also a tiny kerneldoc would be nice (I have
patches somewhere to kerneldocify all the other functions in this file).
-Daniel

> ---
>  drivers/gpu/drm/drm_crtc.c |   16 ++++++++++++++++
>  include/drm/drm_crtc.h     |    1 +
>  2 files changed, 17 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 3b7d32d..8136f09 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -215,6 +215,16 @@ static const struct drm_prop_enum_list drm_encoder_enum_list[] =
>  	{ DRM_MODE_ENCODER_DSI, "DSI" },
>  };
>  
> +static const struct drm_prop_enum_list drm_subpixel_enum_list[] =
> +{
> +	{ SubPixelUnknown, "Unknown" },
> +	{ SubPixelHorizontalRGB, "Horizontal RGB" },
> +	{ SubPixelHorizontalBGR, "Horizontal BGR" },
> +	{ SubPixelVerticalRGB, "Vertical RGB" },
> +	{ SubPixelVerticalBGR, "Vertical BGR" },
> +	{ SubPixelNone, "None" },
> +};
> +
>  void drm_connector_ida_init(void)
>  {
>  	int i;
> @@ -264,6 +274,12 @@ const char *drm_get_connector_status_name(enum drm_connector_status status)
>  }
>  EXPORT_SYMBOL(drm_get_connector_status_name);
>  
> +const char *drm_get_subpixel_order_name(enum subpixel_order order)
> +{
> +	return drm_subpixel_enum_list[order].name;
> +}
> +EXPORT_SYMBOL(drm_get_subpixel_order_name);
> +
>  static char printable_char(int c)
>  {
>  	return isascii(c) && isprint(c) ? c : '?';
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 71727b6..ce9ee60 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -991,6 +991,7 @@ extern void drm_encoder_cleanup(struct drm_encoder *encoder);
>  
>  extern const char *drm_get_connector_name(const struct drm_connector *connector);
>  extern const char *drm_get_connector_status_name(enum drm_connector_status status);
> +extern const char *drm_get_subpixel_order_name(enum subpixel_order order);
>  extern const char *drm_get_dpms_name(int val);
>  extern const char *drm_get_dvi_i_subconnector_name(int val);
>  extern const char *drm_get_dvi_i_select_name(int val);
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch