[Intel-gfx] [PATCH 11/13] drm/i915/bdw: collect semaphore error state

Ben Widawsky ben at bwidawsk.net
Wed Feb 12 01:19:54 CET 2014


On Thu, Jan 30, 2014 at 02:58:09PM +0000, Chris Wilson wrote:
> On Thu, Jan 30, 2014 at 04:53:32PM +0200, Ville Syrjälä wrote:
> > On Wed, Jan 29, 2014 at 11:55:31AM -0800, Ben Widawsky wrote:
> > > +	obj = error->semaphore_obj;
> > > +	if (obj) {
> > 
> > Chris will come along and change this to
> > 
> > if ((obj = error->semaphore_obj))
> 
> I was merely keeping in style with the rest of the code. Which was
> probably written by me, so I can't win!
> -Chris

My choice was intentional. Chris accuses me of polka dotting even when
it wasn't intentional - so why not.

-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list