[Intel-gfx] [PATCH 2/3] drm/i915: Record pid/comm of hanging task

Ben Widawsky ben at bwidawsk.net
Wed Feb 12 19:55:07 CET 2014


On Wed, Feb 12, 2014 at 08:15:58AM +0000, Chris Wilson wrote:
> On Tue, Feb 11, 2014 at 06:07:09PM -0800, Ben Widawsky wrote:
> > I still like my solution which does the strcpy on context creation. Your
> > solution is deferred in the usual case since the hangcheck is
> > asynchronous. The process could be long dead and gone.
> 
> I disliked your solution since there was never a need to copy the string
> upon process creation, you could just have kept a reference to the
> pid...
> 
> > Also, I think my solution is simpler, and with full PPGTT should get the
> > same information.
> 
> I disagree that your solution was simpler and just introduced redundant
> storage.
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

Are you opposed to doing anything at context creation? pid reference
works for me too, or hold on to it with the request - I don't care.

-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list