[Intel-gfx] [PATCH 3/3] drm/i915: Only do gtt cleanup in vma_unbind for the global vma

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 14 14:26:10 CET 2014


On Fri, Feb 14, 2014 at 02:06:07PM +0100, Daniel Vetter wrote:
> Otherwise we end up tearing down fences when e.g. the client quits
> way too early. Might or might not fix a fence pin_count BUG Ville has
> reported.
> 
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Good catch. I am slightly worried that our management of GGTT is
a little haphazard, but given the slightly differing use-cases in
i915_vma_unbind and set_cache_level, this looks cleaner than any
alternative I quickly sketched.

This and the preceding patches are
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list