[Intel-gfx] [PATCH 14/23] drm/i915: remove an indirection level on PC8 functions
Jesse Barnes
jbarnes at virtuousgeek.org
Fri Feb 28 18:11:11 CET 2014
On Thu, 27 Feb 2014 19:26:41 -0300
Paulo Zanoni <przanoni at gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> After the latest changes, the indirection is useless.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 3b57257..ef0bcf8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6673,12 +6673,6 @@ void __hsw_do_enable_pc8(struct drm_i915_private *dev_priv)
> hsw_disable_lcpll(dev_priv, true, true);
> }
>
> -static void __hsw_enable_package_c8(struct drm_i915_private *dev_priv)
> -{
> - WARN_ON(!mutex_is_locked(&dev_priv->pc8.lock));
> - intel_runtime_pm_put(dev_priv);
> -}
> -
> void __hsw_do_disable_pc8(struct drm_i915_private *dev_priv)
> {
> struct drm_device *dev = dev_priv->dev;
> @@ -6706,19 +6700,13 @@ void __hsw_do_disable_pc8(struct drm_i915_private *dev_priv)
> dev_priv->pc8.enabled = false;
> }
>
> -static void __hsw_disable_package_c8(struct drm_i915_private *dev_priv)
> -{
> - WARN_ON(!mutex_is_locked(&dev_priv->pc8.lock));
> - intel_runtime_pm_get(dev_priv);
> -}
> -
> void hsw_enable_package_c8(struct drm_i915_private *dev_priv)
> {
> if (!HAS_PC8(dev_priv->dev))
> return;
>
> mutex_lock(&dev_priv->pc8.lock);
> - __hsw_enable_package_c8(dev_priv);
> + intel_runtime_pm_put(dev_priv);
> mutex_unlock(&dev_priv->pc8.lock);
> }
>
> @@ -6728,7 +6716,7 @@ void hsw_disable_package_c8(struct drm_i915_private *dev_priv)
> return;
>
> mutex_lock(&dev_priv->pc8.lock);
> - __hsw_disable_package_c8(dev_priv);
> + intel_runtime_pm_get(dev_priv);
> mutex_unlock(&dev_priv->pc8.lock);
> }
>
Oh here it is, the next patch in the series. :)
Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list