[Intel-gfx] Supporting fused display configurations v4

Jani Nikula jani.nikula at linux.intel.com
Tue Jan 7 09:23:58 CET 2014


On Tue, 07 Jan 2014, Paulo Zanoni <przanoni at gmail.com> wrote:
> - You removed INTEL_INFO, but all those IS_SOMETHING and HAS_SOMETHING
> macros still accept dev as argument instead of dev_priv. Do we have
> plans to change this too? I can remember many places where I had to
> add a "dev" variable just because of these macros. Perhaps maybe the
> new goal is a series removing the to_i915 macro? I could see a lot of
> code getting almost entirely rid of "dev" with these changes.

You can get from dev to dev_priv and back easily enough. Replacing dev
with dev_priv in function parameters seems like pointless churn to
me. If (and that's a big if) we wanted to "standardize" on one or the
other, I'd go for struct drm_device *dev.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center



More information about the Intel-gfx mailing list