[Intel-gfx] [PATCH] drm/i915: Eliminate lots of WARNs when there's no backlight present

Daniel Vetter daniel at ffwll.ch
Thu Jan 16 17:55:48 CET 2014


On Thu, Jan 16, 2014 at 5:27 PM,  <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> My 855gm doesn't register the intel backlight but it still ends up
> calling the backlight code to enable/disable the backlight via the
> LVDS code. This leads to some WARNs due to backlight.max being 0.
>
> Let's have intel_panel_enable_backlight() and intel_panel_disable_backlight()
> check whether there's a backlight present or not.
>
> Also move the backlight.present check from asle_set_backlight() into
> intel_panel_set_backlight() for some extra symmetry.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Wouldn't that be a perfect machine to test Jani's
init-backlight-from-vbt patch? Iirc all the infrastructure is now
there ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list