[Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

Daniel Vetter daniel at ffwll.ch
Mon Jan 20 20:16:44 CET 2014


On Mon, Jan 20, 2014 at 7:38 PM, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
> We have the same problem already w/ underrun interrupts at least, no?

Yeah, but iirc we've hand-waved over the issue with "hopefully the
bios wm setup never underruns while we take over". If it does we're
screwed ;-)

Wrt vblank interrupts I think we're better off since we initially
disable them, and only enable them on-demand. Presuming that our
interrupt setup code is race-free and properly clears out old
interrupts we should be fine here. So I'm ok with just mentioning that
in the commit message.

For the pipe underrun stuff I guess we could to disable the relevant
interrupt sources at driver bring up first, but maybe we can just wait
with that until the first bug report hits us ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list