[Intel-gfx] [PATCH 07/28] drm/i915: We implement WaMiSetContext_Hang

Rodrigo Vivi rodrigo.vivi at gmail.com
Fri Jan 24 18:30:23 CET 2014


Reviewed-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>

On Wed, Jan 22, 2014 at 5:32 PM,  <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> WaMiSetContext_Hang tells us that a MI_NOOP must follow MI_SET_CONTEXT.
>
> The other thing WaMiSetContext_Hang seems to say is that URB_FENCE isn't
> allowed to straddle two cachelines. But we don't issue those from the
> kernel so we don't care.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_context.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index 112f865..66edc84 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -573,7 +573,10 @@ mi_set_context(struct intel_ring_buffer *ring,
>                         MI_SAVE_EXT_STATE_EN |
>                         MI_RESTORE_EXT_STATE_EN |
>                         hw_flags);
> -       /* w/a: MI_SET_CONTEXT must always be followed by MI_NOOP */
> +       /*
> +        * w/a: MI_SET_CONTEXT must always be followed by MI_NOOP
> +        * WaMiSetContext_Hang:snb,ivb,vlv
> +        */
>         intel_ring_emit(ring, MI_NOOP);
>
>         if (IS_GEN7(ring->dev))
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br



More information about the Intel-gfx mailing list