[Intel-gfx] [PATCH 2/2] drm/i915: read lvds_border_bits state from encoder->get_config

Daniel Vetter daniel at ffwll.ch
Mon Jan 27 11:18:20 CET 2014


On Mon, Jan 27, 2014 at 09:57:11AM +0000, Chris Wilson wrote:
> On Mon, Jan 27, 2014 at 10:00:31AM +0100, Daniel Vetter wrote:
> > We seem to get confused when trying to reconstruct this from the pipe
> > get_config when reading out pfit state. In our code these two are
> > connected, but in the hardware they're not.
> 
> Huh? I think the change is to only read out the border-enable bit when
> LVDS is enabled. But that is only a guess at what your intent is here.

Yeah, that's the idea. The encoder specific get_config is only called if
get_hw_state indicates that the encoder is on. Since we always reset the
lvds border bits in the lvds->mode_set callback to the one in the pipe
config this should fix the mismatch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list