[Intel-gfx] [PATCH] drm/i915: Clean up display pipe register accesses

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 27 13:54:22 CET 2014


On Mon, Jan 27, 2014 at 02:51:53PM +0200, Antti Koskipää wrote:
> On 01/27/14 13:21, Chris Wilson wrote:
> > On Mon, Jan 27, 2014 at 01:17:25PM +0200, Antti Koskipaa wrote:
> >> RFCv2: Reorganize array indexing so that full offsets can be used as
> >> is. It makes grepping for registers in i915_reg.h much easier. Also
> >> move offset arrays to intel_device_info.
> >>
> >> PATCHv1: Fixed offsets for VLV
> >>
> >> Upcoming hardware will not have the various display pipe register
> >> ranges evenly spaced in memory. Change register address calculations
> >> into array lookups.
> >>
> >> Tested on SandyBridge and Valleyview
> > 
> > Please also report changes in object size. If we have people complaining
> > that i915.ko is too big, it helps to point why.
> > -Chris
> 
> Do you want this to be reported in the commit message, or where?

In the commit message.
 
> bloat-o-meter says:
> add/remove: 0/0 grow/shrink: 88/10 up/down: 3326/-518 (2808)

Just use size i915.ko, then we can see how much data and object expands
individually.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list