[Intel-gfx] [PATCH 11/28] drm/i915: WaDisableVDSUnitClockGating isn't applicable to SNB

Rodrigo Vivi rodrigo.vivi at gmail.com
Tue Jan 28 13:13:36 CET 2014


Reviewed-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>

On Wed, Jan 22, 2014 at 5:32 PM,  <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Can't find any mention of WaDisableVDSUnitClockGating ever being
> relevant for SNB. Remove it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 4a1f849..f40dd1b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4605,12 +4605,10 @@ static void gen6_init_clock_gating(struct drm_device *dev)
>          * According to the spec, bit 11 (RCCUNIT) must also be set,
>          * but we didn't debug actual testcases to find it out.
>          *
> -        * Also apply WaDisableVDSUnitClockGating:snb and
> -        * WaDisableRCCUnitClockGating:snb and
> -        * WaDisableRCPBUnitClockGating:snb.
> +        * WaDisableRCCUnitClockGating:snb
> +        * WaDisableRCPBUnitClockGating:snb
>          */
>         I915_WRITE(GEN6_UCGCTL2,
> -                  GEN7_VDSUNIT_CLOCK_GATE_DISABLE |
>                    GEN6_RCPBUNIT_CLOCK_GATE_DISABLE |
>                    GEN6_RCCUNIT_CLOCK_GATE_DISABLE);
>
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br



More information about the Intel-gfx mailing list