[Intel-gfx] [PATCH] drm/i915: fix wait_remaining_ms_from_jiffies

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 29 10:23:18 CET 2014


On Wed, Jan 29, 2014 at 10:52:33AM +0200, Imre Deak wrote:
> Also we should check whether jiffies has overflowed since the timestamp
> for event A was taken. This is highly unlikely on 64 bit, but on 32 bit
> machines jiffies initially is -300*HZ. If the panel power is initially
> off the first wait from edp_panel_vdd_on()->wait_panel_power_cycle()
> will result in a call timestamp_jiffies of 0, so on 32 bit machines we
> would wait ~300 sec + to_wait_ms. Fix this by checking if the initial
> timestamp is not in the future.

Fix the caller. A target + must wait delay set in the future seems like
legal input to me.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list