[Intel-gfx] [PATCH 23/28] drm/i915: gen7_setup_fixed_func_scheduler() actually implements WaVSThreadDispatchOverride

[Rodrigo Vivi]

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>

On Wed, Jan 22, 2014 at 5:32 PM,  <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> The current comments indicate that this function implements
> WaVSRefCountFullforceMissDisable, which is only true for HSW.
> The original purpose of the function is to implement
> WaVSThreadDispatchOverride (and a bit more). Fix up the comments
> to match reality.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index dd68414..766bc8a 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4654,11 +4654,18 @@ static void gen7_setup_fixed_func_scheduler(struct drm_i915_private *dev_priv)
>  {
>         uint32_t reg = I915_READ(GEN7_FF_THREAD_MODE);
>
> +       /*
> +        * WaVSThreadDispatchOverride:ivb,hsw
> +        *
> +        * This actually overrides the dispatch
> +        * mode for all thread types.
> +        */
>         reg &= ~GEN7_FF_SCHED_MASK;
>         reg |= GEN7_FF_TS_SCHED_HW;
>         reg |= GEN7_FF_VS_SCHED_HW;
>         reg |= GEN7_FF_DS_SCHED_HW;
>
> +       /* WaVSRefCountFullforceMissDisable:hsw */
>         if (IS_HASWELL(dev_priv->dev))
>                 reg &= ~GEN7_FF_VS_REF_CNT_FFME;
>
> @@ -4772,7 +4779,6 @@ static void haswell_init_clock_gating(struct drm_device *dev)
>                         I915_READ(GEN7_SQ_CHICKEN_MBCUNIT_CONFIG) |
>                         GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB);
>
> -       /* WaVSRefCountFullforceMissDisable:hsw */
>         gen7_setup_fixed_func_scheduler(dev_priv);
>
>         /* WaDisable4x2SubspanOptimization:hsw */
> @@ -4852,7 +4858,6 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)
>
>         g4x_disable_trickle_feed(dev);
>
> -       /* WaVSRefCountFullforceMissDisable:ivb */
>         gen7_setup_fixed_func_scheduler(dev_priv);
>
>         /* WaDisable4x2SubspanOptimization:ivb */
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br