[Intel-gfx] [PATCH] drm/i915: VM eviction only targets address space not physical pages

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 29 22:55:55 CET 2014


On Wed, Jan 29, 2014 at 12:06:36PM -0800, Ben Widawsky wrote:
> On Tue, Jan 28, 2014 at 06:08:38PM +0000, Chris Wilson wrote:
> > During eviction, we are only considering how to free up space within the
> > current address space and not concerned with freeing up physical memory.
> > As such we need only skip nodes that pinned in the current VM and not
> > globally.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Ben Widawsky <benjamin.widawsky at intel.com>
> 
> Can you rename i915_gem_evict_something() or add a comment at the top
> that the function is not used by the shrinker, and is for evicting a VM?

purge is shrinker freeing up objects for physical pages
evict is eviction freeing up objects for address space

That shrink_all calls evict_everything is just a matter of convenience.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list