[Intel-gfx] [PATCH] drm/i915: Improve the comment on ring_sync after seqno wrap

Chris Wilson chris at chris-wilson.co.uk
Fri Jan 31 12:09:33 CET 2014


On Fri, Jan 31, 2014 at 01:04:21PM +0200, Mika Kuoppala wrote:
> There are quite alot of nasty things happening inside the
> seemingly bening intel_ring_begin() if seqno wrap happens.
> Warn the reader about it.
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ringbuffer.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index d897a19..f99e2ae 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -727,7 +727,13 @@ gen6_ring_sync(struct intel_ring_buffer *waiter,
>  	if (ret)
>  		return ret;
>  
> -	/* If seqno wrap happened, omit the wait with no-ops */
/* If the seqno have wrapped and so reset, omit the wait with no-ops. */
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list