[Intel-gfx] [PATCH 1/3] lib: Always build and export interval_tree

[Michel Lespinasse]

On Sun, Jan 26, 2014 at 3:27 AM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> +config INTERVAL_TREE
> +       boolean
> +        help
> +          Simple, embeddable, interval-tree. Can find the start of an
> +          overlapping range in log(n) time and then iterate over all
> +          overlapping nodes. The algorithm is implemented as an
> +          augmented rbtree.
> +
> +         See:
> +
> +               Documentation/rbtree.txt
> +
> +         for more information.
>
> Though you probably have some better spiel. :)

No, that's fine. I'm not good at writing these things either :)

>> in lib/Kconfig.debug:
>> make INTERVAL_TREE_TEST depend on m && DEBUG_KERNEL && INTERVAL_TREE
>
> Done. Are you sure you do not just want to select INTERVAL_TREE here to
> maintain the status quo?

You're right, select would actually be better.

>> in lib/Makefile:
>> obj-$(CONFIG_INTERVAL_TREE) += interval_tree.o

One more thing I forget, lib/interval_tree_test_main.c should probably
be renamed to interval_tree_test.c and in lib/Makefile the
interval_tree_test-objs line forcing linking of interval_tree.o into
the test module should be removed too.

> Thanks!
> -Chris

I assume you're going to resend with these changes ? I'll be happy to
aprove the patch then :)

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.