[Intel-gfx] [PATCH 0/3] Moving rotation_property to drm_plane

Damien Lespiau damien.lespiau at intel.com
Wed Jul 2 15:17:00 CEST 2014


On Wed, Jul 02, 2014 at 02:21:52PM +0530, Jindal, Sonika wrote:
> Hi,
> 
> Did anybody get a chance to review these patches?

Ok, now those patches are all over the place. It's pretty much
impossible to have the big picture again with the latest changes (the
rotation on drm_plane) nor the limit of the the series, esp. as the
documentation patches have been split off.

I'm not sure why, but it seems like the Cc: tags in your emails have
never actually ended up in the Cc: header of your mails. Which means
they never hit dri-devel. Can you make sure you fix that for the next
resend. This means we haven't gathered their feedback during all this
time...

What you can do: Use --dry-run to make sure you're sending them the
dri-devel. Maybe use the --cc command line option instead?

Also, as already mentioned, don't send the patches to the LKML, noone
will review them there.

Could you resend the full series with the reviewed-by tags gathered so
far? with dri-devel in copy? in a separarte mail thread? We usually
version the big resend of series in the cover letter, explaning the
changes.

Thanks,

-- 
Damien



More information about the Intel-gfx mailing list