[Intel-gfx] [PATCH 3/8] drm/i915: Rename ctx->is_initialized to ctx->rcs_is_initialized

Mateo Lozano, Oscar oscar.mateo at intel.com
Thu Jul 3 14:09:32 CEST 2014


> -----Original Message-----
> From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
> Sent: Thursday, July 03, 2014 10:49 AM
> To: Mateo Lozano, Oscar
> Cc: intel-gfx at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 3/8] drm/i915: Rename ctx->is_initialized to
> ctx->rcs_is_initialized
> 
> On Thu, Jun 26, 2014 at 02:24:14PM +0100, oscar.mateo at intel.com wrote:
> > From: Oscar Mateo <oscar.mateo at intel.com>
> >
> > We only use this flag to signify that the render state (a.k.a. golden
> > context, a.k.a. null context) has been initialized. It doesn't mean
> > anything for the other engines, so make that distinction obvious.
> > This renaming was suggested by Daniel Vetter.
> >
> > Implemented with this cocci script (plus manual changes to the struct
> > declaration):
> >
> > 	@
> > 	struct intel_context c;
> > 	@@
> > 	- (c).is_initialized
> > 	+ c.rcs_is_initialized
> >
> > 	@@
> > 	struct intel_context *c;
> > 	@@
> > 	- (c)->is_initialized
> > 	+ c->rcs_is_initialized
> >
> > No functional changes.
> >
> > Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
> 
> Ugh. This works better with the rearrangement, and
> s/rcs_is_initialized/rcs_initialised/

ACK to the renaming. Re the rearrangement, I replied in the previous conservation.



More information about the Intel-gfx mailing list