[Intel-gfx] [PATCH 16/16] drm/i915: Get the error state over the wire (HACKish)

Chris Wilson chris at chris-wilson.co.uk
Fri Jul 4 10:02:35 CEST 2014


On Tue, Jul 01, 2014 at 11:17:51AM -0700, Ben Widawsky wrote:
> I was dealing with a bug recently where the system would hard hang
> somewhere between hangcheck and reset. There was time after error
> collection to actually get my error state out, but I couldn't get the
> reads to work.
> 
> This patch is also useful for when reset kills the machine, and you want
> to keep reset enabled but still get error state.
> 
> Since I found the patch pretty useful, I decided to clean it up and
> submit it. It was mostly meant as a one-off hack originally though.
> 
> If a maintainer decides it's useful, then here it is.

I think we could certainly push the register dump into DRM_DEBUG. That's
usually enough to identify duplicates and so may be useful from the dev
perspective. Or throw in a QA parameter that dumps an interesting subset to
KERN_ERR. Most people seem to manage to include the dmesg so getting the
right information into it would reduce some of the annoyance in vague
bug reports. (Too much of the wrong information though is equally
annoying.)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list