[Intel-gfx] [PATCH 1/8] drm/i915: Extract context backing object allocation

[Chris Wilson]

On Thu, Jul 03, 2014 at 04:27:58PM +0100, oscar.mateo at intel.com wrote:
> From: Oscar Mateo <oscar.mateo at intel.com>
> 
> This is preparatory work for Execlists: we plan to use it later to
> allocate our own context objects (since Logical Ring Contexts do
> not have the same kind of backing objects).
> 
> No functional changes.
> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>

The series looks fine. My gripe is that the split between context and
ring is messy (I think that a context is now a view of the entire
hardware state and so our bookkeeping should reflect that) and leads to
some subtle bugs where the bookkeeping on the ring is not transferred
correctly to the context. However, this series is a good starting point
to fix the more esoteric problems.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre