[Intel-gfx] [PATCH 2/2] drm/i915: Use mmio flips to change tiling mode on Baytrail

[Daniel Vetter]

On Tue, Jul 08, 2014 at 10:40:30AM +0100, Chris Wilson wrote:
> For whatever reason, MI_DISPLAY_FLIP fails to change tiling mode on
> Baytrail, so just use CPU driven mmio flips instead.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76176
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Both merged to dinq with the bz link for the first patch added.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 103d8f450e74..8a9695697380 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9453,6 +9453,9 @@ static bool use_mmio_flip(struct intel_engine_cs *ring,
>  	 * So using MMIO flips there would disrupt this mechanism.
>  	 */
>  
> +	if (ring == NULL)
> +		return true;
> +
>  	if (INTEL_INFO(ring->dev)->gen < 5)
>  		return false;
>  
> @@ -9747,6 +9750,9 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
>  
>  	if (IS_VALLEYVIEW(dev)) {
>  		ring = &dev_priv->ring[BCS];
> +		if (obj->tiling_mode != work->old_fb_obj->tiling_mode)
> +			/* vlv: DISPLAY_FLIP fails to change tiling */
> +			ring = NULL;
>  	} else if (IS_IVYBRIDGE(dev)) {
>  		ring = &dev_priv->ring[BCS];
>  	} else if (INTEL_INFO(dev)->gen >= 7) {
> -- 
> 2.0.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch