[Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 9 18:04:40 CEST 2014


On Wed, Jul 09, 2014 at 08:59:29AM -0700, Volkin, Bradley D wrote:
> On Wed, Jul 09, 2014 at 08:30:08AM -0700, Chris Wilson wrote:
> > You need to check that the shrinker hasn't truncated your backing
> > storage whilst it was marked DONTNEED. It just amounts to checking for
> > obj->madv == __I915_MADV_PURGED in pool_get() and discarding the cache
> > entry if it has been truncated.
> 
> Ok. When we hit a purged object, do you think it's worth doing a retry loop (as
> in libdrm's cache) or just fall straight through to allocating a new object?

I'd keeping going through the cache, deleting purged entries until we
find a usable object (or we have cleared the list).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list