[Intel-gfx] [PATCH i-g-t 1/2] drv_module_reload: Don't declare success when failing

Damien Lespiau damien.lespiau at intel.com
Thu Jul 10 15:17:42 CEST 2014


We weren't returning straight away when failing to unload the driver, so
the test happilly executed gem_suspend and printed ""module successfully
loaded again".

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
---
 tests/drv_module_reload | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/drv_module_reload b/tests/drv_module_reload
index c1fd395..66cd6bb 100755
--- a/tests/drv_module_reload
+++ b/tests/drv_module_reload
@@ -33,10 +33,9 @@ rmmod drm &> /dev/null
 
 if lsmod | grep i915 &> /dev/null ; then
 	echo WARNING: i915.ko still loaded!
-	exitcode=1
+	exit 1
 else
 	echo module successfully unloaded
-	exitcode=0
 fi
 
 modprobe i915
@@ -47,4 +46,4 @@ modprobe snd_hda_intel
 # try to run something
 $SOURCE_DIR/gem_exec_nop > /dev/null && echo "module successfully loaded again"
 
-exit $exitcode
+exit 0
-- 
1.8.3.1




More information about the Intel-gfx mailing list