[Intel-gfx] [PATCH 11/11] drm/i915: Enable PSR by default.

Daniel Vetter daniel at ffwll.ch
Sat Jul 12 12:05:13 CEST 2014


On Fri, Jul 11, 2014 at 10:30:19AM -0700, Rodrigo Vivi wrote:
> Panel Self Refresh is an eDP power saving feature specified by VESA's eDP v1.3,
> that allows some panel componets to shutdown while you still see static images on
> the screen. Besides being supported on the platform it must be supported by the
> eDP panel itself.
> 
> Now that we have the propper frontbuffer tracking support and correct locks on place
> we can enabled this feature by default.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Yay!

Entire series pulled in, thanks a lot for the testing and review.

Besides byt psr the big chunk is now polishing the testcase. Iirc I've
written down a detailed description of the task in internal jira and
assigned it to you, right?

I want to have the tests before we enable byt psr to make sure we really
catch all the regressions that might crop up.

Thanks, Daniel

> ---
>  drivers/gpu/drm/i915/i915_params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 8145729..bbdee21 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -37,7 +37,7 @@ struct i915_params i915 __read_mostly = {
>  	.enable_fbc = -1,
>  	.enable_hangcheck = true,
>  	.enable_ppgtt = -1,
> -	.enable_psr = 0,
> +	.enable_psr = 1,
>  	.preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT),
>  	.disable_power_well = 1,
>  	.enable_ips = 1,
> @@ -118,7 +118,7 @@ MODULE_PARM_DESC(enable_ppgtt,
>  	"(-1=auto [default], 0=disabled, 1=aliasing, 2=full)");
>  
>  module_param_named(enable_psr, i915.enable_psr, int, 0600);
> -MODULE_PARM_DESC(enable_psr, "Enable PSR (default: false)");
> +MODULE_PARM_DESC(enable_psr, "Enable PSR (default: true)");
>  
>  module_param_named(preliminary_hw_support, i915.preliminary_hw_support, int, 0600);
>  MODULE_PARM_DESC(preliminary_hw_support,
> -- 
> 1.9.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list