[Intel-gfx] [PATCH 07/10] drm/i915/bdw: collect semaphore error state

[Ben Widawsky]

On Mon, Jul 14, 2014 at 11:04:22AM +0100, Damien Lespiau wrote:
> On Mon, Jun 30, 2014 at 09:53:41AM -0700, Rodrigo Vivi wrote:
> > +	for_each_ring(useless, dev_priv, i) {
> > +		u16 signal_offset =
> > +			(GEN8_SIGNAL_OFFSET(ring, i) & PAGE_MASK) / 4;
> > +		u32 *tmp = error->semaphore_obj->pages[0];
> > +
> > +		ering->semaphore_mboxes[i] = tmp[signal_offset];
> > +		ering->semaphore_seqno[i] = ring->semaphore.sync_seqno[i];
> > +	}
> > +}
> 
> This loops around all the rings, but semaphore_mboxes[] and
> semaphore_seqno[] are of size (I915_NUM_RINGS - 1).
> 
> -- 
> Damien

Dan Carpenter has already reported this to us. I was expecting a patch
from Rodrigo.

-- 
Ben Widawsky, Intel Open Source Technology Center