[Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

[Paulo Zanoni]

2014-07-17 13:58 GMT-03:00 Daniel Vetter <daniel at ffwll.ch>:
> On Thu, Jul 17, 2014 at 3:29 PM, Paulo Zanoni <przanoni at gmail.com> wrote:
>> I can do this, but please notice that we already have
>> power-well-checking code in many of the other assertions on our
>> driver... And it will probably be just a matter of time since someone
>> starts using the assertions again on a place where the power well can
>> be disabled :)
>
> The only one I've found outside of the hw state readout code and error
> capture code (and there we obviously need them) is in assert_pipe.
> This was added in 693101618a4be. Tbh I wonder whether we could revert
> that with the patch to ditch the assert from intel_crtc_disable?

I was talking about all that hw state readout code (which are also
used as assertions) and basically every single caller of
intel_display_power_enabled().

> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch



-- 
Paulo Zanoni