[Intel-gfx] [PATCH 04/12] drm/i915: Add wrapper function for intel_crtc_set_config()

[Paulo Zanoni]

2014-07-14 16:10 GMT-03:00 Todd Previte <tprevite at gmail.com>:
> Add a wrapper around intel_crtc_set_config() to allow it to be called from the
> DP compliance test functions. This is necessary to perform the internal mode
> set operations required for compliance testing.
>
> Signed-off-by: Todd Previte <tprevite at gmail.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 6 ++++++
>  drivers/gpu/drm/i915/intel_drv.h     | 2 ++
>  2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index fa77557..77ab4f3 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11249,6 +11249,12 @@ out_config:
>         return ret;
>  }
>
> +/* Wrapper function for setting a configuration for DP compliance testing */
> +int intel_dp_set_config(struct drm_mode_set *set)
> +{
> +       return intel_crtc_set_config(set);

Why not just export intel_crtc_set_config(), since the wrapper does
nothing but call the wrapped thing? I see you don't change this
function on the other patches.


> +}
> +
>  static const struct drm_crtc_funcs intel_crtc_funcs = {
>         .gamma_set = intel_crtc_gamma_set,
>         .set_config = intel_crtc_set_config,
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 5f7c7bd..d2ae54f 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -836,6 +836,8 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode,
>                                  struct intel_crtc_config *pipe_config);
>  int intel_format_to_fourcc(int format);
>  void intel_crtc_wait_for_pending_flips(struct drm_crtc *crtc);
> +/* Wrapper function for setting a configuration for DP compliance testing */
> +int intel_dp_set_config(struct drm_mode_set *set);
>
>
>  /* intel_dp.c */
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni