[Intel-gfx] [PATCH 06/12] drm/i915: Add a constant and function for getting the Displayport compliance failsafe video mode

[Paulo Zanoni]

2014-07-14 16:10 GMT-03:00 Todd Previte <tprevite at gmail.com>:
> Adds the failsafe mode (640x480 at 60hz) as a constant and a function that retrieves it. These are
> designed for use in Displayport compliance testing only and should not be used outside that
> context.
>
> Signed-off-by: Todd Previte <tprevite at gmail.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 6c8f222..33b6dc9 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -82,6 +82,18 @@ static const struct dp_link_dpll chv_dpll[] = {
>                 { .p1 = 2, .p2 = 1, .n = 1, .m1 = 2, .m2 = 0x6c00000 } }
>  };
>
> +/* VESA 640x480 at 60Hz - DP compliance failsafe mode */
> +static struct drm_display_mode dp_failsafe_mode = {
> +       DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 25200, 640, 664, 752,
> +                        800, 0, 480, 490, 492, 525, 0,
> +                        DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC)
> +};
> +
> +struct drm_display_mode *intel_dp_get_failsafe_mode(void)

Since on patch 7 you call this from intel_dp.c, and you never add a
forward declaration to any .h file, I guess this function should be
static, right? Also, I'd squash it into patch 7.

> +{
> +       return &dp_failsafe_mode;
> +}
> +
>  /**
>   * is_edp - is the given port attached to an eDP panel (either CPU or PCH)
>   * @intel_dp: DP struct
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni