[Intel-gfx] [PATCH 1/2] drm/i915: Allow overlapping userptr objects

Daniel Vetter daniel at ffwll.ch
Wed Jul 23 16:34:22 CEST 2014


On Wed, Jul 23, 2014 at 02:23:53PM +0100, Tvrtko Ursulin wrote:
> Looks fine. Performance impact is potentially big as we discussed but I
> suppose we can leave that for later if an issue. So:
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Merged, thanks for patch and review.

> I think it would be good to add some more tests to cover the tracking
> "handover" between the interval tree and linear list to ensure invalidation
> still works correctly in non-trivial cases. Code looks correct in that
> respect but just in case. It is not a top priority so not sure when I'll
> find time to actually do it.

We don't yet have some tests with overlapping allocations? I think at
least some basic smoke test should be there ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list