[Intel-gfx] [PATCH] igt_core: Inject subtest message into dmesg

[Chris Wilson]

On Thu, Jul 24, 2014 at 02:03:01PM +0100, Thomas Wood wrote:
> On 24 July 2014 13:36, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Thu, Jul 24, 2014 at 12:48:33PM +0100, Chris Wilson wrote:
> >> One of the side-effects we test for are kernel oops and knowing the
> >> guilty subtest can help speed up debugging. We can write to /dev/kmsg to
> >> inject messages into dmesg, so let's do so before the start of every
> >> test.
> >>
> >> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >
> > Should we change proc->comm too? Would help with the oops printing ... Ack
> > on the patch itself.
> 
> It should also make sure that the log level is appropriate so that the
> Piglit dmesg capture isn't triggered accidentally.

I found out how to set the log-level, so choose KERN_INFO which should be
sufficient.
 
> Would it be useful to include this in simple tests (tests without
> subtests) as well?

Definitely. Is there a way to do that automatically or do we need to
adjust the tests themselves? I was thinkg we could add a kmsg() to
common_init() to capture those.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre