[Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

Chris Wilson chris at chris-wilson.co.uk
Sat Jul 26 12:27:38 CEST 2014


On Wed, Jun 18, 2014 at 10:54:13PM +0200, Daniel Vetter wrote:
> On Fri, Jun 13, 2014 at 04:38:03PM +0100, oscar.mateo at intel.com wrote:
> > From: Oscar Mateo <oscar.mateo at intel.com>
> > 
> > Or with a spinlock grabbed, because it might sleep, which is not
> > a nice thing to do. Instead, do the runtime_pm get/put together
> > with the create/destroy request, and handle the forcewake get/put
> > directly.
> > 
> > Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
> 
> Looks like a fixup that should be squashed into relevant earlier patches.

The whole gen6_gt_force_wake_get() calling intel_runtime_pm_get() is
broken due to this - we must be able to read registers in atomic
context!

Please revert c8c8fb33b37766acf6474784b0d5245dab9a1690
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list