[Intel-gfx] [PATCH v10] drm/i915: Replaced Blitter ring based flips with MMIO flips

[Chris Wilson]

On Mon, Jun 02, 2014 at 10:38:13AM +0000, Gupta, Sourab wrote:
> On Mon, 2014-06-02 at 06:56 +0000, Chris Wilson wrote:
> > On Sun, Jun 01, 2014 at 04:43:13PM +0530, sourab.gupta at intel.com wrote:
> > > +static bool use_mmio_flip(struct intel_engine_cs *ring,
> > > +			  struct drm_i915_gem_object *obj)
> > > +{
> > > +	 /* This is not being used for older platforms, because
> > > +	 * non-availability of flip done interrupt forces us to use
> > > +	 * CS flips. Older platforms derive flip done using some clever
> > > +	 * tricks involving the flip_pending status bits and vblank irqs.
> > > +	 * So using MMIO flips there would disrupt this mechanism.
> > > +	 */
> > > +
> > > +	if (INTEL_INFO(ring->dev)->gen < 5)
> > > +		return false;
> > > +
> > > +	if (i915.use_mmio_flip < 0)
> > > +		return false;
> > > +	else if (i915.use_mmio_flip > 0)
> > > +		return true;
> > > +	else
> > > +		return ring != obj->ring;
> > > +}
> > 
> > Check whitespace.
> > 
> Hi Chris,
> Couldn't get the whitespace error here, and at other places. Also,
> checkpatch.pl doesn't show any. Can you please point out the error.

It's the alignment of
/*
 *
 */
that needs to be checked, and later the if (ret == 0) looks to be using
a mixture of tabs and spaces.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre