[Intel-gfx] [PATCH] [I-G-T]Add rc6_residency_counter subtest

Daniel Vetter daniel at ffwll.ch
Thu Jun 5 21:16:13 CEST 2014


On Thu, Jun 5, 2014 at 7:19 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
> On Thu, Jun 05, 2014 at 10:27:42AM +0800, Wendy Wang wrote:
>> Move rc6_residency_check to subtest, add new rc6_residency_counter subtest
>> for pm_rc6_residency IGT case.
>>
>
> Looks good to me. You have some formatting issues:
>  for loops don't use the right coding style
>  useless comment to fopen
>  bad sign-off in mail
>  added unnecessary whitespace
>  replace assert with open coded abort
>
> So I've merged it with all those warts (except I fixed the
> signed-off-by). Please keep these things in mind next patch, and feel
> free to submit patches to fix these issues as well.

I guess you've missed my reply to Wendy's patch. Since you've gone
ahead and merged it, can you please address these issues?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list