[Intel-gfx] [PATCH v2 1/2] drm/i915: fix possible refcount leak when resetting forcewake

Daniel Vetter daniel at ffwll.ch
Fri Jun 6 19:46:19 CEST 2014


On Fri, Jun 06, 2014 at 12:08:43PM +0100, Chris Wilson wrote:
> On Fri, Jun 06, 2014 at 02:04:37PM +0300, Imre Deak wrote:
> > If the timer putting the last forcewake refcount was pending and we
> > canceled it, we'll leak the corresponding forcewake and RPM references.
> > 
> > v2:
> > - do the ptr casting at the caller instead of adding a separate helper
> >   for this (Chris)
> > 
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Both patches merged to dinq (Chris clarified on irc that his r-b is for
both). Since this only blows up in a super-contrived testcase I don't
think this is material for -fixes.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list