[Intel-gfx] [PATCH v2 1/2] drm/i915: fix possible refcount leak when resetting forcewake

Jani Nikula jani.nikula at linux.intel.com
Tue Jun 10 18:35:53 CEST 2014


On Fri, 06 Jun 2014, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Fri, Jun 6, 2014 at 10:44 PM, Imre Deak <imre.deak at intel.com> wrote:
>> Let's say that forcewake timer is pending, holding the runtime pm ref.
>> System suspend is called - it's not prevented by either this ref or the
>> above autosuspend delay - in the suspend handler we eventually call
>> force_wake_reset which cancels the timer, leaking the runtime pm ref.
>
> Hm, I indeed mixed things up. I guess the window is small with the
> short timeout we have for the forcewake timer, but still the first
> patch makes sense for -fixes. Jani?

v2 of 1/2 pushed to -fixes, thanks for that patch and review.

BR,
Jani.


> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center



More information about the Intel-gfx mailing list