[Intel-gfx] [PATCH] drm/i915: Print PCI revision in i915_dump_device_info()

[Daniel Vetter]

On Fri, Jun 13, 2014 at 03:39:56PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Knowing the device stepping may be crucial in analyzing problems. Since
> we always ask bug reporters for dmegs with drm.debug=0xe (or something)
> it would be nice if the PCI revision is already included in the dump.
> Avoids having to ask for lspci output as well.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
> ---
>  drivers/gpu/drm/i915/i915_dma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 7c63b18..aadb0c9 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -1493,10 +1493,11 @@ static void i915_dump_device_info(struct drm_i915_private *dev_priv)
>  #define SEP_EMPTY
>  #define PRINT_FLAG(name) info->name ? #name "," : ""
>  #define SEP_COMMA ,
> -	DRM_DEBUG_DRIVER("i915 device info: gen=%i, pciid=0x%04x flags="
> +	DRM_DEBUG_DRIVER("i915 device info: gen=%i, pciid=0x%04x rev=0x%02x flags="
>  			 DEV_INFO_FOR_EACH_FLAG(PRINT_S, SEP_EMPTY),
>  			 info->gen,
>  			 dev_priv->dev->pdev->device,
> +			 dev_priv->dev->pdev->revision,
>  			 DEV_INFO_FOR_EACH_FLAG(PRINT_FLAG, SEP_COMMA));
>  #undef PRINT_S
>  #undef SEP_EMPTY
> -- 
> 1.8.5.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch